[plugin-mobile-app] Add possibility to swipe the context #1939

ikalinin1 · 2021-09-03T14:52:17Z

Closes #1933

valfirst · 2021-09-03T14:57:33Z

docs/modules/plugins/pages/plugin-mobile-app.adoc

@@ -436,6 +436,9 @@ When I clear field located `accessibilityId(username)`

 Swipes to an element in either UP, DOWN, LEFT, or RIGHT direction with the specified swipe duration

+[INFO]
+Step takes into account current context. If you need to perform swipe on the element, swith the context to the element.


Suggested change

Step takes into account current context. If you need to perform swipe on the element, swith the context to the element.

The step takes into account current context. If you need to perform swipe on the element, you need to switch the context to this element.

valfirst · 2021-09-03T14:58:18Z

vividus-extension-selenium/src/main/java/org/vividus/ui/context/IUiContext.java

@@ -39,4 +41,7 @@
    List<WebElement> getAssertingWebElements();

    boolean withAssertingWebElements(List<WebElement> elements, BooleanSupplier asserter);
+
+    <R, T extends SearchContext> R calculateWhen(Class<T> expectedClazz, Function<T, R> valueCalculator,
+            Supplier<R> defaultValueProvider);


looks like not a part of UI context

valfirst · 2021-09-03T14:59:12Z

...ual-testing/src/test/java/org/vividus/visual/screenshot/WebAdjustingCoordsProviderTests.java

@@ -70,6 +72,7 @@
    void testGetCoordsNotIOS()
    {
        mockScrollbarActions();
+        Mockito.doReturn(null).when(uiContext).getSearchContext();


it's better to use static import for consistency

valfirst · 2021-09-03T14:59:52Z

...ual-testing/src/test/java/org/vividus/visual/screenshot/WebAdjustingCoordsProviderTests.java

+                argThat(a -> {
+                    return expectedCoords.equals(a.get());
+                }))).thenReturn(expectedCoords);


useless change?

valfirst · 2021-09-03T15:00:26Z

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/model/SwipeArea.java

+import org.openqa.selenium.Dimension;
+import org.openqa.selenium.Point;
+
+public class SwipeArea


org.openqa.selenium.Rectangle

codecov · 2021-09-03T15:05:51Z

Codecov Report

Merging #1939 (9b11330) into master (72dd535) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1939   +/-   ##
=========================================
  Coverage     96.01%   96.01%           
- Complexity     5294     5298    +4     
=========================================
  Files           751      751           
  Lines         15107    15117   +10     
  Branches       1029     1030    +1     
=========================================
+ Hits          14505    14515   +10     
  Misses          469      469           
  Partials        133      133

Impacted Files	Coverage Δ
...rg/vividus/bdd/mobileapp/model/SwipeDirection.java	`100.00% <100.00%> (ø)`
...va/org/vividus/bdd/mobileapp/steps/TouchSteps.java	`100.00% <100.00%> (ø)`
...ava/org/vividus/mobileapp/action/TouchActions.java	`98.36% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17901c...9b11330. Read the comment docs.

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/TouchSteps.java

valfirst

Also unit test coverage is below the threshold

sonarqubecloud · 2021-09-08T08:34:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

ikalinin1 marked this pull request as draft September 3, 2021 14:52

valfirst requested changes Sep 3, 2021

View reviewed changes

ikalinin1 force-pushed the contextual-swipe branch from ddb855a to 3b1f692 Compare September 7, 2021 08:02

ikalinin1 requested review from uarlouski, valfirst and abudevich September 7, 2021 08:03

ikalinin1 marked this pull request as ready for review September 7, 2021 08:03

ikalinin1 force-pushed the contextual-swipe branch from 3b1f692 to 137fef5 Compare September 7, 2021 15:41

valfirst requested changes Sep 8, 2021

View reviewed changes 8000

vividus-plugin-mobile-app/src/main/java/org/vividus/bdd/mobileapp/steps/TouchSteps.java Show resolved Hide resolved

valfirst reviewed Sep 8, 2021

View reviewed changes

[plugin-mobile-app] Add possibility to swipe the context

9b11330

ikalinin1 force-pushed the contextual-swipe branch from 137fef5 to 9b11330 Compare September 8, 2021 08:18

valfirst approved these changes Sep 8, 2021

View reviewed changes

uarlouski approved these changes Sep 8, 2021

View reviewed changes

valfirst merged commit c6ab617 into master Sep 8, 2021

valfirst deleted the contextual-swipe branch September 8, 2021 11:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[plugin-mobile-app] Add possibility to swipe the context #1939

[plugin-mobile-app] Add possibility to swipe the context #1939

	Step takes into account current context. If you need to perform swipe on the element, swith the context to the element.
	The step takes into account current context. If you need to perform swipe on the element, you need to switch the context to this element.

[plugin-mobile-app] Add possibility to swipe the context #1939

[plugin-mobile-app] Add possibility to swipe the context #1939

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Codecov Report

Choose a reason for hiding this comment