8000 Add ability to interact with shadow dom elements by abudevich · Pull Request #1912 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ability to interact with shadow dom elements #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2021
Merged

Add ability to interact with shadow dom elements #1912

merged 2 commits into from
Oct 8, 2021

Conversation

abudevich
Copy link
Contributor
@abudevich abudevich commented Aug 27, 2021 •
edited by valfirst
Loading

Closes #1494

@abudevich abudevich self-assigned this Aug 27, 2021
@abudevich abudevich marked this pull request as draft August 27, 2021 08:25
@abudevich abudevich marked this pull request as ready for review August 27, 2021 08:26
valfirst
valfirst reviewed Aug 27, 2021
View reviewed changes
Copy link
Collaborator
@valfirst valfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add integration tests

@abudevich abudevich marked this pull request as draft August 27, 2021 10:49
@abudevich abudevich force-pushed the 1494-shadow-dom branch 7 times, most recently from e72b07a to aa812ff Compare September 23, 2021 13:51
@abudevich abudevich force-pushed the 1494-shadow-dom branch 4 times, most recently from 9f99524 to 4a2228c Compare September 30, 2021 13:40
@abudevich abudevich requested a review from valfirst September 30, 2021 13:43
@abudevich abudevich marked this pull request as ready for review September 30, 2021 13:43
valfirst
valfirst requested changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator
@valfirst valfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs describing new locator

@abudevich abudevich force-pushed the 1494-shadow-dom branch 4 times, most recently from 95bac84 to 8723c3d Compare October 4, 2021 07:08
@abudevich abudevich requested a review from valfirst October 4, 2021 08:23
@abudevich abudevich force-pushed the 1494-shadow-dom branch 2 times, most recently from 6453e42 to 07c3f59 Compare October 4, 2021 09:21
@abudevich abudevich requested a review from valfirst October 5, 2021 08:35
@abudevich abudevich requested a review from valfirst October 5, 2021 09:55
valfirst
valfirst requested changes Oct 5, 2021
View reviewed changes
Copy link
Collaborator
@valfirst valfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpotBugs violation failed the builds

@abudevich abudevich force-pushed the 1494-shadow-dom branch 2 times, most recently from b98dea0 to e5425cc Compare October 5, 2021 13:52
@abudevich abudevich requested a review from valfirst October 5, 2021 13:54
@abudevich abudevich force-pushed the 1494-shadow-dom branch 2 times, most recently from fe97e17 to c79bf5c Compare October 6, 2021 13:02
ikalinin1
ikalinin1 reviewed Oct 7, 2021
View reviewed changes
...gin-web-app/src/test/java/org/vividus/ui/web/action/search/ShadowCssSelectorSearchTests.java Outdated
import org.vividus.ui.action.search.ShadowDomSearchParameters;
import org.vividus.ui.action.search.Visibility;

public class ShadowCssSelectorSearchTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch with filtering by visibility is not covered

@valfirst valfirst added this to the 0.3.10 milestone Oct 7, 2021
uarlouski
uarlouski reviewed Oct 8, 2021
View reviewed changes
vividus-plugin-web-app/src/main/java/org/vividus/ui/web/action/search/WebLocatorType.java
.map(String::strip)
.collect(Collectors.toList());
String targetValue = searchValues.get(searchValues.size() - 1);
String upperShadowHost = searchValues.get(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to use remove instead of get? then you won't need the stream below

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doubtful comment

@valfirst valfirst merged commit b69961d into vividus-framework:master Oct 8, 2021
@abudevich abudevich deleted the 1494-shadow-dom branch November 2, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst requested changes

@ikalinin1 ikalinin1 ikalinin1 approved these changes

@uarlouski uarlouski uarlouski approved these changes

Assignees

@abudevich abudevich

Labels
None yet
Projects
None yet
Milestone
0.3.10
Development

Successfully merging this pull request may close these issues.

Accessing Shadow DOM elements
4 participants
@abudevich @valfirst @ikalinin1 @uarlouski
0