[extension-selenium] Increase allowed published har size to 40 mb #5547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
0802e59 to
1a8a34a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5547 +/- ##
=========================================
Coverage 97.68% 97.68%
Complexity 7302 7302
=========================================
Files 982 982
Lines 20512 20516 +4
Branches 1343 1343
=========================================
+ Hits 20037 20041 +4
Misses 362 362
Partials 113 113 ☔ View full report in Codecov by Sentry. |
valfirst
reviewed
Nov 26, 2024
| @@ -64,7 +66,16 @@ public PublishingHarOnFailureMonitor(boolean publishHarOnFailure, EventBus event | |||
| this.testContext = testContext; | |||
| this.mapperFactory = new MapperFactory() | |||
| { | |||
| private final Supplier<ObjectMapper> objectMapper = Suppliers.memoize(ObjectMapper::new); | |||
| private static final int ALLOWED_HAR_SIZE = 40_000_000; | |||
There was a problem hiding this comment.
- please add an information about exception which was hit before this fix
- add the note to the documentation describing the current limit
1a8a34a to
6451675
Compare
6451675 to
c3d5637
Compare
|
valfirst
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.