Combine Shadow DOM sources into a single attachment in the report #5433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d4ac3e to
d2c620d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5433 +/- ##
=========================================
Coverage 97.65% 97.65%
- Complexity 7027 7042 +15
=========================================
Files 971 976 +5
Lines 20405 20441 +36
Branches 1336 1341 +5
=========================================
+ Hits 19926 19962 +36
Misses 368 368
Partials 111 111 ☔ View full report in Codecov by Sentry. |
valfirst
requested changes
Oct 11, 2024
| @@ -48,6 +49,10 @@ public void onAssertionFailure(AssertionFailedEvent event) | |||
| if (publishSourceOnFailure && webDriverProvider.isWebDriverInitialized()) | |||
| { | |||
| contextSourceCodeProvider.getSourceCode().forEach(this::publishSource); | |||
| if (publishShadowDomSourceOnFailure) | |||
| { | |||
| publishShadowDomSource(); | |||
There was a problem hiding this comment.
Generic SourceCodePublishingOnFailureListener should know nothing about Shadow DOM, because this class is used in both web-app and mobile-app plugins
410efec to
01bcdda
Compare
valfirst
reviewed
Oct 17, 2024
vividus-engine/src/main/java/org/vividus/condition/AbstractBooleanPropertyCondition.java
Show resolved
Hide resolved
01bcdda to
c1e967a
Compare
valfirst
requested changes
Oct 18, 2024
| import org.springframework.stereotype.Component; | ||
| import org.vividus.condition.AbstractBooleanPropertyCondition; | ||
|
|
||
| @Component |
There was a problem hiding this comment.
why is this annotation needed?
| import org.springframework.stereotype.Component; | ||
| import org.vividus.condition.AbstractBooleanPropertyCondition; | ||
|
|
||
| @Component |
| private boolean publishSourceOnFailure; | ||
| private String format; | ||
| @Autowired | ||
| private String sourceCodeAttachmentFormat; |
There was a problem hiding this comment.
you are lucky, because there is only one bean of type String
c1e967a to
fb0f3ed
Compare
valfirst
requested changes
Oct 23, 2024
| @@ -23,4 +23,6 @@ public interface ContextSourceCodeProvider | |||
| String APPLICATION_SOURCE_CODE = "Application source code"; | |||
|
|
|||
| Map<String, String> getSourceCode(); | |||
|
|
|||
| Map<String, String> getShadowDomSourceCode(); | |||
There was a problem hiding this comment.
it is applicable for web only, thus we should introduce it in vividus-extension-web-app
| <meta charset="utf-8"> | ||
| <title>Application source code</title> | ||
| <link rel="stylesheet" href="../../styles.css"/> | ||
| <link rel="stylesheet" href="../../webjars/bootstrap/3.4.1/css/bootstrap.min.css"/> |
f45da12 to
31a2449
Compare
31a2449 to
05f982c
Compare
valfirst
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.