8000 [plugin-web-app] Add option to limit screenshots max height by draker94 · Pull Request #5270 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[plugin-web-app] Add option to limit screenshots max height #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

[plugin-web-app] Add option to limit screenshots max height #5270

merged 1 commit into from
Aug 2, 2024

Conversation

draker94
Copy link
Contributor
@draker94 draker94 commented Aug 1, 2024

No description provided.

@draker94 draker94 requested a review from a team as a code owner August 1, 2024 15:15
@github-actions GitHub Actions
Copy link
github-actions bot commented Aug 1, 2024 •
edited
Loading

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov Codecov
Copy link
codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.62%. Comparing base (0469ff0) to head (f0ac2fd).
Report is 1 commits behind head on master.

Files Patch % Lines
.../ui/web/screenshot/WebScreenshotConfiguration.java 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5270      +/-   ##
============================================
+ Coverage     97.51%   97.62%   +0.11%     
- Complexity     6931     6941      +10     
============================================
  Files           956      956              
  Lines         20105    20117      +12     
  Branches       1322     1323       +1     
============================================
+ Hits          19605    19639      +34     
+ Misses          392      368      -24     
- Partials        108      110       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@draker94 draker94 force-pushed the add_ability_to_limit_screenshot_height branch from 5855539 to b21ac3e Compare August 1, 2024 15:56
@draker94 draker94 force-pushed the add_ability_to_limit_screenshot_height branch from b21ac3e to f0ac2fd Compare August 2, 2024 06:44
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@valfirst valfirst merged commit 25c9710 into master Aug 2, 2024
9 of 10 checks passed
@valfirst valfirst deleted the add_ability_to_limit_screenshot_height branch August 2, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@vkepin vkepin Awaiting requested review from vkepin vkepin is a code owner automatically assigned from vividus-framework/maintainers

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@draker94 @valfirst @web-flow
0