Add DisableBrowserFetching property to AppliTools plagin #4913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Mar 19, 2024
| @@ -154,6 +155,8 @@ private void testDefaultParameters(Supplier<List<ApplitoolsVisualCheck>> checksS | |||
| converter.setAppName(appName); | |||
| String baselineEnvName = "default-baseline-env-name"; | |||
| converter.setBaselineEnvName(baselineEnvName); | |||
| Boolean disableBrowserFetching = false; | |||
There was a problem hiding this comment.
Updated. Thanks!
7b1d32b to
d910ec0
Compare
uarlouski
reviewed
Mar 19, 2024
...n/java/org/vividus/visual/eyes/converter/ExamplesTableToApplitoolsVisualChecksConverter.java
Show resolved
Hide resolved
valfirst
reviewed
Mar 19, 2024
d910ec0 to
bcd2ce5
Compare
a48c982 to
160fc3a
Compare
160fc3a to
cb5635f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4913 +/- ##
=========================================
Coverage 97.38% 97.38%
- Complexity 6597 6598 +1
=========================================
Files 921 921
Lines 19067 19071 +4
Branches 1269 1269
=========================================
+ Hits 18569 18573 +4
Misses 390 390
Partials 108 108 ☔ View full report in Codecov by Sentry. |
valfirst
reviewed
Mar 20, 2024
912B
uarlouski
approved these changes
Mar 20, 2024
valfirst
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.