8000 [vividus-util] Use getRawAuthority() in buildNewUrl method to get the original encoded authority value by TykovkaV · Pull Request #4638 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[vividus-util] Use getRawAuthority() in buildNewUrl method to get the original encoded authority value #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

[vividus-util] Use getRawAuthority() in buildNewUrl method to get the original encoded authority value #4638

merged 1 commit into from
Dec 8, 2023

Conversation

TykovkaV
Copy link
Contributor
@TykovkaV TykovkaV commented Dec 5, 2023

No description provided.

@TykovkaV TykovkaV requested a review from a team as a code owner December 5, 2023 09:29
@codecov Codecov
Copy link
codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e90344d) 97.38% compared to head (37d45a0) 97.39%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #4638      +/-   ##
============================================
+ Coverage     97.38%   97.39%   +0.01%     
+ Complexity     6761     6526     -235     
============================================
  Files           914      914              
  Lines         18789    18789              
  Branches       1249     1249              
============================================
+ Hits          18298    18300       +2     
+ Misses          384      383       -1     
+ Partials        107      106       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TykovkaV TykovkaV force-pushed the uri-utils-v2 branch 2 times, most recently from c462233 to f598371 Compare December 5, 2023 15:47
valfirst
valfirst requested changes Dec 6, 2023
View reviewed changes
vividus-util/src/main/java/org/vividus/util/UriUtils.java
@@ -323,7 +323,7 @@ public static URI buildNewUrl(URI url, String relativeUrl)
throw new IllegalArgumentException(String
.format("Relative path '%s' for '%s' should start with forward slash ('/')", path, url));
}
String uriAsString = createUriAsString(url.getScheme(), url.getAuthority(), encodeNonAsciiChars(path),
String uriAsString = createUriAsString(url.getScheme(), url.getRawAuthority(), encodeNonAsciiChars(path),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add unit tests

@TykovkaV TykovkaV changed the title url-utils-v2 [vividus-util] Use getRawAuthority() in buildNewUrl method to get the original encoded authority value Dec 8, 2023
@valfirst valfirst merged commit 101f9fb into vividus-framework:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@vkepin vkepin Awaiting requested review from vkepin vkepin is a code owner automatically assigned from vividus-framework/maintainers

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TykovkaV @valfirst
0