[plugin-web-app-to-rest-api] Add ability to set headers for headless … #4598
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4598 +/- ##
==========================================
Coverage 97.39% 97.39%
+ Complexity 6728 6499 -229
==========================================
Files 907 911 +4
Lines 18680 18704 +24
Branches 1241 1241
==========================================
+ Hits 18193 18217 +24
- Misses 380 381 +1
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
1bb02ec to
5ce5a06
Compare
| @@ -182,6 +182,16 @@ a|`true` | |||
| |`true` | |||
| |Whether to crawl https pages. | |||
|
|
|||
| |`transformer.from-headless-crawling.default-headers.<header name>=<header value>` | |||
There was a problem hiding this comment.
the doc should be updated now
| @SuppressWarnings({ "EmptyPublicCtorInClass", "RedundantModifier" }) | ||
| private final class Http | ||
| { | ||
| public Http() |
There was a problem hiding this comment.
required by jackson: non-static inner classes like this can only by instantiated using default, no-argument constructor
There was a problem hiding this comment.
is package-private an option here?
There was a problem hiding this comment.
no, it has to be public
| } | ||
|
|
||
| @SuppressWarnings({ "EmptyPublicCtorInClass", "RedundantModifier" }) | ||
| private final class Http |
There was a problem hiding this comment.
avoid mixing visibility modifiers, either make everything private or public
There was a problem hiding this comment.
or maybe package-private?
There was a problem hiding this comment.
made everything private
5ce5a06 to
ca76f7e
Compare
2180ad3 to
1540fff
Compare
1540fff to
4bc990f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
…crawler requests