8000 [plugin-web-app] Fix assertion messages in step switching to new tab by valfirst · Pull Request #4517 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[plugin-web-app] Fix assertion messages in step switching to new tab #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

valfirst
Copy link
Collaborator
@valfirst valfirst commented Nov 1, 2023

No description provided.

@valfirst valfirst requested a review from a team as a code owner November 1, 2023 11:05
Copy link
codecov bot commented Nov 1, 2023

Codecov Report

Merging #4517 (d80ff07) into master (1c389cf) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4517      +/-   ##
============================================
+ Coverage     97.31%   97.33%   +0.01%     
- Complexity     6437     6439       +2     
============================================
  Files           894      894              
  Lines         18561    18570       +9     
  Branches       1239     1238       -1     
============================================
+ Hits          18063    18075      +12     
+ Misses          389      388       -1     
+ Partials        109      107       -2     
Files Coverage Δ
...java/org/vividus/steps/ui/web/SetContextSteps.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
github-actions bot commented Nov 1, 2023

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Number of placeholders does not match number of arguments in logging call 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit a164807 into master Nov 1, 2023
@valfirst valfirst deleted the fix-assertion-messages-in-step-switching-to-new-tab branch November 1, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0