Change the syntax of the steps for Video Steps #4474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc179ac to
05b687c
Compare
020f329 to
b078c30
Compare
Codecov Report
@@ Coverage Diff @@
## master #4474 +/- ##
============================================
+ Coverage 97.31% 97.33% +0.01%
+ Complexity 6451 6442 -9
============================================
Files 894 894
Lines 18558 18547 -11
Branches 1241 1241
============================================
- Hits 18059 18052 -7
+ Misses 389 388 -1
+ Partials 110 107 -3
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
uarlouski
reviewed
Oct 26, 2023
| When I play video in video player located by `$locator` | ||
| ---- | ||
|
|
||
| _Deprecated syntax (will be removed in VIVIDUS 0.8.0)_: |
There was a problem hiding this comment.
0.7.0 here and in other places
b078c30 to
45a8dda
Compare
valfirst
approved these changes
Oct 27, 2023
uarlouski
approved these changes
Oct 30, 2023
valfirst
requested changes
Oct 30, 2023
| Given I initialize scenario variable `pausedTime` with value `${details.currentTime}` | ||
| Then element located by `<videoLocator>` exists for `PT1S` duration | ||
| When I save info from video player located by `<videoLocator>` to SCENARIO variable `details` | ||
| Then пш`${details.currentTime}` is = `${pausedTime}` |
There was a problem hiding this comment.
Suggested change
| Then пш`${details.currentTime}` is = `${pausedTime}` | |
| Then `${details.currentTime}` is = `${pausedTime}` |
fe94729 to
7e9941c
Compare
valfirst
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.