8000 [plugin-lighthouse] Set max cacheable score to 99 by uarlouski · Pull Request #4417 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[plugin-lighthouse] Set max cacheable score to 99 #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

[plugin-lighthouse] Set max cacheable score to 99 #4417

merged 1 commit into from
Oct 10, 2023

Conversation

uarlouski
Copy link
Member

No description provided.

@uarlouski uarlouski requested a review from a team as a code owner October 9, 2023 11:51
@uarlouski uarlouski marked this pull request as draft October 9, 2023 12:13
@uarlouski uarlouski force-pushed the feature/reduce-max-score branch from c72f021 to bda0810 Compare October 9, 2023 14:18
@uarlouski uarlouski marked this pull request as ready for review October 9, 2023 14:19
@github-actions
Copy link
github-actions bot commented Oct 9, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link
codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #4417 (bda0810) into master (984f536) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #4417   +/-   ##
=========================================
  Coverage     97.31%   97.31%           
  Complexity     6451     6451           
=========================================
  Files           894      894           
  Lines         18558    18558           
  Branches       1241     1241           
=========================================
  Hits          18059    18059           
  Misses          389      389           
  Partials        110      110
Files Coverage Δ
...n/java/org/vividus/lighthouse/LighthouseSteps.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link
sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@valfirst valfirst merged commit 0a20c13 into master Oct 10, 2023
@valfirst valfirst deleted the feature/reduce-max-score branch October 10, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

@draker94 draker94 Awaiting requested review from draker94 draker94 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uarlouski @valfirst
0