[plugin-web-app-to-rest-api] Add jump links verifications #4367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
eed23b1 to
73a6c19
Compare
Codecov Report
@@ Coverage Diff @@
## master #4367 +/- ##
============================================
- Coverage 97.31% 97.30% -0.02%
- Complexity 6383 6388 +5
============================================
Files 892 892
Lines 18393 18402 +9
Branches 1223 1225 +2
============================================
+ Hits 17900 17906 +6
- Misses 384 385 +1
- Partials 109 111 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valfirst
requested changes
Sep 27, 2023
| @@ -198,7 +216,7 @@ private static String getElementUri(Element element) | |||
| String href = element.attr(HREF_ATTR); | |||
| if (!href.isEmpty()) | |||
| { | |||
| if (URL_FRAGMENT.equals(href)) | |||
| if (href.equals(URL_FRAGMENT) || isJumpLink(href)) | |||
There was a problem hiding this comment.
Suggested change
| if (href.equals(URL_FRAGMENT) || isJumpLink(href)) | |
| if (URL_FRAGMENT.equals(href) || isJumpLink(href)) |
| @@ -29,7 +29,9 @@ public enum ResourceValidationError | |||
| EMPTY_HREF_SRC("Element doesn't contain href/src attributes", | |||
| "Element by selector %s doesn't contain href/src attributes"), | |||
| INVALID_HREF_SRC("Element has href/src attribute with invalid URL: %s", | |||
| "Element by selector %s has href/src attribute with invalid URL: %s"); | |||
| "Element by selector %s has href/src attribute with invalid URL: %s"), | |||
| UNEXISTENT_JUMPLINK_TARGET("Jump link points to unexistent element with %s id", | |||
There was a problem hiding this comment.
Suggested change
| UNEXISTENT_JUMPLINK_TARGET("Jump link points to unexistent element with %s id", | |
| MISSING_JUMPLINK_TARGET("Jump link points to missing element with %s id", |
| "Element by selector %s has href/src attribute with invalid URL: %s"); | ||
| "Element by selector %s has href/src attribute with invalid URL: %s"), | ||
| UNEXISTENT_JUMPLINK_TARGET("Jump link points to unexistent element with %s id", | ||
| "Jump link by selector %s points to unexistent element with %s id"); |
There was a problem hiding this comment.
Suggested change
| "Jump link by selector %s points to unexistent element with %s id"); | |
| "Jump link by selector %s points to missing element with %s id"); |
73a6c19 to
3b8f968
Compare
3b8f968 to
17b3852
Compare
|
Kudos, SonarCloud Quality Gate passed! |
valfirst
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.