[extension-selenium] Add step to wait an element with text matching r… #4349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Sep 22, 2023
| @@ -415,6 +415,23 @@ Then element located by `$locator` exists for `$duration` duration | |||
| Then element located by `id(banner)` exists for `PT5S` duration | |||
| ---- | |||
|
|
|||
| === Wait element has text matching regex | |||
There was a problem hiding this comment.
Suggested change
| === Wait element has text matching regex | |
| === Wait until element has text matching regular expression |
| When I wait until element located by `$locator` has text matching `$regex` | ||
| ---- | ||
|
|
||
| * `$locator` - The <<_locator>> of the element whose text to check. |
There was a problem hiding this comment.
Suggested change
| * `$locator` - The <<_locator>> of the element whose text to check. | |
| * `$locator` - The <<_locator>> of the element which text to check. |
vividus-extension-selenium/src/main/java/org/vividus/steps/ui/GenericWaitSteps.java
Show resolved
Hide resolved
Comment on lines
10
to
11
| When I change context to element located by `id(current-horizontal):a` | ||
| Then the text matches '\d+' |
There was a problem hiding this comment.
Suggested change
| When I change context to element located by `id(current-horizontal):a` | |
| Then the text matches '\d+' |
| Given I am on page with URL `${vividus-test-site-url}/scrollableElements.html` | ||
| When I change context to element located by `id(scrollable)` | ||
| When I scroll context to RIGHT edge | ||
| When I reset context | ||
| When I wait until element located by `id(current-horizontal):a` has text matching `\d+` | ||
| When I change context to element located by `id(current-horizontal):a` | ||
| Then the text matches '\d+' | ||
|
|
There was a problem hiding this comment.
also it makes sense to update the test scrolling to bottom
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov Report
@@ Coverage Diff @@
## master #4349 +/- ##
============================================
+ Coverage 97.27% 97.29% +0.02%
- Complexity 6330 6341 +11
============================================
Files 886 886
Lines 18193 18229 +36
Branches 1211 1212 +1
============================================
+ Hits 17697 17736 +39
+ Misses 385 384 -1
+ Partials 111 109 -2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
67a433d to
7043df0
Compare
|
Kudos, SonarCloud Quality Gate passed! |
valfirst
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…egex