Unify syntax of set context steps #4288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
valfirst
requested changes
Aug 31, 2023
| [source,gherkin] | ||
| ---- | ||
| When I switch to frame located `$locator` | ||
| ---- | ||
|
|
||
| * `$locator` - <<_locator>>. |
There was a problem hiding this comment.
please make it more meanigful
| */ | ||
| @Deprecated(since = "0.6.0", forRemoval = true) | ||
| @Replacement(versionToRemoveStep = "0.7.0", | ||
| replacementFormatPattern = "When I switch to frame located by `$locator`") |
There was a problem hiding this comment.
Suggested change
| replacementFormatPattern = "When I switch to frame located by `$locator`") | |
| replacementFormatPattern = "When I switch to frame located by `%1$s`") |
| public void switchToFrame(Locator locator) | ||
| { | ||
| resetContext(); | ||
| baseValidations.assertElementExists("The frame to switch", locator).ifPresent(frameActions::switchToFrame); |
There was a problem hiding this comment.
Suggested change
| baseValidations.assertElementExists("The frame to switch", locator).ifPresent(frameActions::switchToFrame); | |
| baseValidations.assertElementExists("The frame to switch context", locator).ifPresent(frameActions::switchToFrame); |
a6459b8 to
9e5c3b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #4288 +/- ##
=========================================
Coverage 97.21% 97.21%
- Complexity 6363 6364 +1
=========================================
Files 889 889
Lines 18317 18321 +4
Branches 1210 1210
=========================================
+ Hits 17807 17811 +4
Misses 400 400
Partials 110 110
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
valfirst
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.