10000 [vividus] Mark deprecated composite steps in printing steps task by draker94 · Pull Request #4062 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[vividus] Mark deprecated composite steps in printing steps task #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

[vividus] Mark deprecated composite steps in printing steps task #4062

merged 1 commit into from
Jun 22, 2023

Conversation

draker94
Copy link
Contributor
@draker94 draker94 commented Jun 20, 2023 •
edited
Loading

Closes #4048

@draker94 draker94 requested a review from a team as a code owner June 20, 2023 13:47
@draker94 draker94 force-pushed the print_deprecated_composed_steps branch from 39f7a24 to 50c1ceb Compare June 21, 2023 09:53
@codecov
Copy link
codecov bot commented Jun 21, 2023 •
edited
Loading

Codecov Report

Merging #4062 (658b094) into master (5efe2ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #4062   +/-   ##
=========================================
  Coverage     97.19%   97.19%           
  Complexity     6420     6420           
=========================================
  Files           893      893           
  Lines         18472    18477    +5     
  Branches       1211     1213    +2     
=========================================
+ Hits          17953    17958    +5     
  Misses          410      410           
  Partials        109      109
Impacted Files Coverage Δ
.../replacement/DeprecatedCompositeStepsReporter.java 100.00% <100.00%> (ø)
...va/org/vividus/runner/DeprecatedStepsReplacer.java 98.50% <100.00%> (ø)
...src/main/java/org/vividus/runner/StepsPrinter.java 88.31% <100.00%> (+0.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@draker94 draker94 force-pushed the print_deprecated_composed_steps branch 2 times, most recently from fe772fa to fce7b32 Compare June 21, 2023 10:30
@draker94 draker94 force-pushed the print_deprecated_composed_steps branch from fce7b32 to 658b094 Compare June 21, 2023 12:10
@valfirst valfirst merged commit 9823126 into vividus-framework:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uarlouski uarlouski uarlouski left review comments

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve printSteps to print deprecation message for composite steps
4 participants
@draker94 @valfirst @uarlouski @web-flow
0