[plugin-applitools] Add execution cloud support #4059
Conversation
QodanaIt seems all right 👌 No new problems found according to the checks applied Contact Qodana teamContact us at qodana-support@jetbrains.com
|
8b3f843 to
65bd0c0
Compare
QodanaIt seems all right 👌 No new problems found according to the checks applied Contact Qodana teamContact us at qodana-support@jetbrains.com
|
vividus-extension-selenium/src/main/java/org/vividus/selenium/AbstractWebDriverFactory.java
Outdated
Show resolved
Hide resolved
65bd0c0 to
3a9fb2e
Compare
QodanaIt seems all right 👌 No new problems found according to the checks applied Contact Qodana teamContact us at qodana-support@jetbrains.com
|
3a9fb2e to
c73004d
Compare
QodanaIt seems all right 👌 No new problems found according to the checks applied Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov Report
@@ Coverage Diff @@
## master #4059 +/- ##
============================================
- Coverage 97.20% 88.78% -8.42%
- Complexity 6420 6656 +236
============================================
Files 893 897 +4
Lines 18473 18501 +28
Branches 1211 1212 +1
============================================
- Hits 17957 16427 -1530
- Misses 409 1945 +1536
- Partials 107 129 +22
... and 73 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
|
||
| :plugin-short-name: applitools | ||
| include::partial$plugin-installation.adoc[] | ||
|
|
||
| == Properties | ||
| == UI validations |
There was a problem hiding this comment.
| == UI validations | |
| == Visual Testing |
|
|
||
| |`<empty>` | ||
| |The name of the application under test. | ||
| include::partial$applitools-properties.adoc[] |
There was a problem hiding this comment.
no need to duplicate the properties, just move the to the separate section at the very beginnging
There was a problem hiding this comment.
its not convenient at all when properties are spread across the whole page
|
|
||
| == Execution cloud | ||
|
|
||
| https://applitools.com/platform/execution-cloud/[Execution Cloud] is a self-healing test infrastructure for running resilient tests using OS frameworks. |
There was a problem hiding this comment.
using OS frameworks.
what is it?
There was a problem hiding this comment.
There was a problem hiding this comment.
I wouldn't copy it without clear understanding
| [cols="1,2"] | ||
| |=== | ||
|
|
||
| |`executioncloud/web` |
There was a problem hiding this comment.
| |`executioncloud/web` | |
| |`applitools/web` |
There was a problem hiding this comment.
applitools is not clear because its a company name, whereas executioncloud is a product that the profile is created for
| @@ -1,3 +1,3 @@ | |||
| === `ESTABLISH` | |||
| ==== `ESTABLISH` | |||
There was a problem hiding this comment.
it will affect other plugins, use leveloffset: https://docs.asciidoctor.org/asciidoc/latest/directives/include-with-leveloffset/
| @@ -1,6 +1,7 @@ | |||
| applitools.server-uri= | |||
| applitools.execute-api-key= | |||
| applitools.app-name=Application under test | |||
| applitools.execution-cloud.batch-name=VIVIDUS test run | |||
There was a problem hiding this comment.
to group stories under one batch
|
|
||
| spring.profiles.active=web,executioncloud | ||
|
|
||
| selenium.grid.capabilities.browserName=chrome |
There was a problem hiding this comment.
shouldn't it be ../web/chrome profile?
| @@ -68,4 +68,17 @@ | |||
| <idref bean="visualTestingSteps" /> | |||
| <idref bean="ufgSteps" /> | |||
| </util:list> | |||
|
|
|||
| <beans profile="executioncloud"> | |||
| <bean class="org.vividus.executioncloud.selenium.ExecutionCloudUrlProvider" primary="true" /> | |||
There was a problem hiding this comment.
isn't profile order enough to set the order of beans loading?
There was a problem hiding this comment.
no, why did you think so?
There was a problem hiding this comment.
- VIVIDUS profiles order matters
- If Spring loads profiles exactly in the same order they defined, then we should rely on bean loading order, rather then marking some beans primary
There was a problem hiding this comment.
vividus is vividus, spring is spring, so order of profiles in spring doesn't make early loaded beans primary over lately loaded
c73004d to
8cb15fe
Compare
QodanaIt seems all right 👌 No new problems found according to the checks applied Contact Qodana teamContact us at qodana-support@jetbrains.com
|
8cb15fe to
8d0bb29
Compare
QodanaIt seems all right 👌 No new problems found according to the checks applied Contact Qodana teamContact us at qodana-support@jetbrains.com
|
| @@ -1,13 +1,13 @@ | |||
| = Applitools Plugin | |||
|
|
|||
| The plugin provides the ability to perform visual testing using the https://applitools.com/[Applitools] visual testing platform. | |||
| The plugin provides the ability to perform various kinds of testing using the https://applitools.com/[Applitools] services such as https://applitools.com/platform/eyes/[Eyes] https://applitools.com/platform/ultrafast-grid/[Ultrafast Grid] and https://applitools.com/platform/execution-cloud/[Execution Cloud]. | |||
There was a problem hiding this comment.
| The plugin provides the ability to perform various kinds of testing using the https://applitools.com/[Applitools] services such as https://applitools.com/platform/eyes/[Eyes] https://applitools.com/platform/ultrafast-grid/[Ultrafast Grid] and https://applitools.com/platform/execution-cloud/[Execution Cloud]. | |
| The plugin provides the ability to perform various kinds of testing using the https://applitools.com/[Applitools] services such as https://applitools.com/platform/eyes/[Eyes], https://applitools.com/platform/ultrafast-grid/[Ultrafast Grid] and https://applitools.com/platform/execution-cloud/[Execution Cloud]. |
| |Description | ||
|
|
||
| |`applitools.execution-cloud.batch-name` | ||
| |VIVIDUS test run |
There was a problem hiding this comment.
I don't think we should put any default value here
|
|
||
| import java.net.URL; | ||
|
|
||
| public class WebDriverUrlProvider implements RemoteWebDriverUrlProvider |
There was a problem hiding this comment.
| public class WebDriverUrlProvider implements RemoteWebDriverUrlProvider | |
| public class StaticRemoteWebDriverUrlProvider implements RemoteWebDriverUrlProvider |
?
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.vividus.executioncloud; |
There was a problem hiding this comment.
| package org.vividus.executioncloud; | |
| package org.vividus.applitools.executioncloud; |
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.vividus.executioncloud; |
There was a problem hiding this comment.
| package org.vividus.executioncloud; | |
| package org.vividus.applitools.executioncloud; |
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.vividus.executioncloud.selenium; |
There was a problem hiding this comment.
| package org.vividus.executioncloud.selenium; | |
| package org.vividus.applitools.executioncloud; |
8d0bb29 to
b44f1e5
Compare
QodanaIt seems all right 👌 No new problems found according to the checks applied Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.