8000 [vividus] Add ability to replace deprecated steps automatically by draker94 · Pull Request #4027 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[vividus] Add ability to replace deprecated steps automatically #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related 10000 emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2023
Merged

[vividus] Add ability to replace deprecated steps automatically #4027

merged 1 commit into from
Jun 19, 2023

Conversation

draker94
Copy link
Contributor
@draker94 draker94 commented Jun 7, 2023

(+ replaced steps in stories for debug)

@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch from 7461139 to a982226 Compare June 7, 2023 14:42
valfirst
valfirst requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator
@valfirst valfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some TODOs:

  • think of integration/system test(s)
  • create PR to build system repo
  • document Gradle task
  • document overall process of deprecating steps (in Developer Guides)
    • how to deprecate regular step
    • how to deprecate composite step
    • describe the ways to find deprecated steps (logging, check gradle task printing steps)
    • describe process of deprecated steps removal

@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch 3 times, most recently from 6b7bc4f to d299e24 Compare June 12, 2023 10:51
@codecov
Copy link
codecov bot commented Jun 12, 2023 •
edited
Loading

Codecov Report

Merging #4027 (e4f3eff) into master (de0367f) will increase coverage by 7.76%.
The diff coverage is 98.55%.

@@             Coverage Diff              @@
##             master    #4027      +/-   ##
============================================
+ Coverage     89.42%   97.19%   +7.76%     
+ Complexity     6643     6417     -226     
============================================
  Files           892      893       +1     
  Lines         18334    18470     +136     
  Branches       1194     1210      +16     
============================================
+ Hits          16396    17951    +1555     
+ Misses         1809      410    -1399     
+ Partials        129      109      -20
Impacted Files Coverage Δ
.../main/java/org/vividus/steps/ui/web/PageSteps.java 98.82% <ø> (ø)
.../main/java/org/vividus/steps/ui/web/WaitSteps.java 100.00% <ø> (ø)
...va/org/vividus/runner/DeprecatedStepsReplacer.java 98.50% <98.50%> (ø)
.../replacement/DeprecatedCompositeStepsReporter.java 100.00% <100.00%> (ø)
...vividus/steps/api/HttpResponseValidationSteps.java 99.09% <100.00%> (+0.02%) ⬆️

... and 72 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch 4 times, most recently from ed8243c to 9c9d17a Compare June 14, 2023 07:22
@draker94 draker94 marked this pull request as ready for review June 14, 2023 07:37
@draker94 draker94 requested a review from a team as a code owner June 14, 2023 07:37
@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch from 9c9d17a to 6f20c74 Compare June 15, 2023 08:09
valfirst
valfirst requested changes Jun 15, 2023
View reviewed changes
@valfirst valfirst mentioned this pull request Jun 15, 2023
Closed
@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch 2 times, most recently from 9bd4c4a to 4829d64 Compare June 15, 2023 12:19
@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch from 4829d64 to 300821c Compare June 15, 2023 19:33
@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch from 300821c to 62cac1c Compare June 16, 2023 07:53
@valfirst valfirst requested a review from uarlouski June 16, 2023 08:25
@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch 2 times, most recently from e12747f to 0006509 Compare June 16, 2023 09:54
@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch from 0006509 to e0e8c56 Compare June 19, 2023 07:42
@draker94 draker94 force-pushed the add_replace_deprecate_steps_task branch from e0e8c56 to e4f3eff Compare June 19, 2023 08:11
@valfirst valfirst merged commit ecd85aa into vividus-framework:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@uarlouski uarlouski uarlouski approved these changes

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@draker94 @valfirst @uarlouski @web-flow
0