10000 [plugin-accessiblity] Remove redundant symbol from axe report by uarlouski · Pull Request #4024 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[plugin-accessiblity] Remove redundant symbol from axe report #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2023
Merged

[plugin-accessiblity] Remove redundant symbol from axe report #4024

merged 2 commits into from
Jun 7, 2023

Conversation

uarlouski
Copy link
Member

No description provided.

@uarlouski uarlouski requested a review from a team as a code owner June 7, 2023 08:55
@uarlouski uarlouski requested review from valfirst and ikalinin1 June 7, 2023 08:55
@codecov
Copy link
codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #4024 (ac7a544) into master (2aec0a5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4024   +/-   ##
=========================================
  Coverage     97.18%   97.18%           
  Complexity     6398     6398           
=========================================
  Files           892      892           
  Lines         18256    18256           
  Branches       1186     1186           
=========================================
  Hits          17743    17743           
  Misses          406      406           
  Partials        107      107

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@valfirst
Copy link
Collaborator
valfirst commented Jun 7, 2023

in general it makes sense to fix a typo, and then do refactoring

@valfirst valfirst self-requested a review June 7, 2023 10:30
@uarlouski uarlouski force-pushed the remove-redundant-symbol branch from fc50d06 to ac7a544 Compare June 7, 2023 12:11
C542
@sonarqubecloud
Copy link
sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@valfirst valfirst merged commit d3f11da into master Jun 7, 2023
@valfirst valfirst deleted the remove-redundant-symbol branch June 7, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@ikalinin1 ikalinin1 Awaiting requested review from ikalinin1 ikalinin1 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uarlouski @valfirst
0