8000 AttestationReport: Improving parsing and writing by larrydewey · Pull Request #309 · virtee/sev · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AttestationReport: Improving parsing and writing #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

larrydewey
Copy link
Contributor
  • Added two inline functions to reduce the duplication when parsing or writing attestation bytes.

  • Only returing on instance of the object when parsing the bytes now.

@auto-assign auto-assign bot requested a review from ryansavino May 27, 2025 15:32
@larrydewey larrydewey force-pushed the improvements branch 5 times, most recently from aab6974 to c9e38d5 Compare May 28, 2025 15:34
- Added two inline functions to reduce the duplication when parsing or
  writing attestation bytes.

- Only returing on instance of the object when parsing the bytes now.

Signed-off-by: Larry Dewey <larry.dewey@amd.com>
Copy link
Member
@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member
@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tylerfanelli tylerfanelli merged commit 355edae into virtee:main May 29, 2025
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0