8000 Firmware: Fix attestation report save to file for report versions >=3 on preTurin by soelangen · Pull Request #307 · virtee/sev · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Firmware: Fix attestation report save to file for report versions >=3 on preTurin #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Firmware: Fix attestation report save to file for report versions >=3 on preTurin #307

merged 1 commit into from
May 16, 2025

Conversation

soelangen
Copy link
Contributor

Generating a report with snpguest tooling on a VM running on GCP with report version 4 and firmware version 1.55.31 on a Milan CPU is getting saved as Turin report. Therefore a malformed report is getting saved and verification is failing.

As I have not found any public information about version 4 of the report structure and the verification of the report is successful with snpguest tooling including this fix, I assume that no major changes have occured to the report structure.

References:
https://github.com/google/go-sev-guest/pull/158/files Changes to googles SEV go library for report version 4 and firmware 1.55.31.

@soelangen
Firmware: Fix attestation report save to file for report versions >=3…
8991eff 
… on preTurin

Signed-off-by: Sören Langenberg <soeren@enclaive.io>
DGonzalezVillal
DGonzalezVillal approved these changes May 9, 2025
View reviewed changes
Copy link
Member
@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, version 4 changes of the report are internal, so the contents can't be added to this repo yet, but this was definitely a logic oversight from our part. Appreciate the PR!

tylerfanelli
tylerfanelli approved these changes May 9, 2025
View reviewed changes
Copy link
Member
@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was an oversight as I believe version 4 isn't publicly available yet. Thanks for the contribution.

@tylerfanelli tylerfanelli merged commit 3afbffe into virtee:main May 16, 2025
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerfanelli tylerfanelli tylerfanelli approved these changes

@DGonzalezVillal DGonzalezVillal DGonzalezVillal approved these changes

@larrydewey larrydewey Awaiting requested review from larrydewey larrydewey is a code owner

Assignees

@larrydewey larrydewey

@DGonzalezVillal DGonzalezVillal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soelangen @tylerfanelli @DGonzalezVillal @larrydewey
0