idblocks: support a few other PEM formats #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that OpenSSL generates several types of PEM formats for
private keys. The 'BEGIN PRIVATE KEY' is the PKCS8 format, but
previously there was the EC 'legacy', which can still be used and
generated successfully by OpenSSL. Among these, there are also
encrypted PEM keys, which start with the 'BEGIN ENCRYPTED
8000
PRIVATE KEY'
line and can also be used.
This patch extends support for PEM formats by adding two more: EC
legacy ("BEGIN EC PRIVATE KEY") and PKCS8 encrypted ("BEGIN ENCRYPTED
PRIVATE KEY").
Why bother? The following commands are all valid and generate three
PEM keys:
```bash
openssl genpkey -algorithm EC -pkeyopt ec_paramgen_curve:secp384r1 -out id-block-key.pem
```
```bash
openssl ecparam -name secp384r1 -genkey -noout -out id-block-key.pem
```
```bash
openssl genpkey -algorithm EC -pkeyopt ec_paramgen_curve:secp384r1 -aes256 -out id-block-key.pem
```
but only the first one is supported by the `sev` library. This commit
fixes the issue without any cost.
Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
tylerfanelli
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that OpenSSL generates several types of PEM formats for private keys. The 'BEGIN PRIVATE KEY' is the PKCS8 format, but previously there was the EC 'legacy', which can still be used and generated successfully by OpenSSL. Among these, there are also encrypted PEM keys, which start with the 'BEGIN ENCRYPTED PRIVATE KEY' line and can also be used.
This patch extends support for PEM formats by adding two more: EC legacy ("BEGIN EC PRIVATE KEY") and PKCS8 encrypted ("BEGIN ENCRYPTED PRIVATE KEY").
Why bother? The following commands are all valid and generate three PEM keys:
but only the first one is supported by the
sevlibrary. This commit fixes the issue without any cost.