Fix our dockerfile (once again) #245
Conversation
If we try to build florestad outside the git tree, it will fail because the build script assumes we are inside one. But while building the Dockerfile and nix flake, we don't get the git files, so the build.rs breaks in those cases. This commit adds a fallback, where if we can't get the version using git, we use the one declared in our Cargo.toml.
If we use rust's official image, we may have a problem of incompatible libc when running on ubuntu latest, so we use the exact same image to build, but drop the build tools after we get floresta built.
This will make sure that we won't silently break the dockerfile in the future
8aa14a5 to
cf4229b
Compare
For sure. |
Why not? |
failures:
tests::test_get_block
tests::test_get_block_hash
tests::test_get_block_header
tests::test_get_blockchaininfo
tests::test_get_height
tests::test_get_roots
tests::test_send_raw_transaction
tests::test_stopi didnt debuged but, i did literally git clone git@github.com:vinteumorg/floresta.git
cd floresta
cargo testEven if its a missing thing that floresta depends, this cannot happen. |
|
You have to cargo build first, it's in the readme |
As i said, something that i missed. But i still thinks thats something not ideal to the project. I see two good ways to make this work:
Anyway, this issue is not place for discuss this. Lets open another one to track this if you liked the idea. |
This should fix a few problems with the dockerfile. It also adds a CI build for it, so we won't have breaking changes being merged in the future.
I think the nix build would also benefit from having a CI check (not implemented here)