Remove the cli_wire module
#528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module is no longer exposed nor used anywhere, so it can be a bit confusing to keep a folder with dead code. Also something like this could be implemented manually by users via our `p2p_wire` traits.
Davidson-Souza
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
ACK c0dc6cb
A follow-up idea: move p2p wire to the root of floresta-wire. I don't think we want to have anything that's not p2p there anyway...
|
ACK c0dc6cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
This module is no longer exposed nor used anywhere, so it can be a bit confusing to keep a folder with dead code. Also something like this could be implemented manually by users via our
p2p_wiretraits.