8000 [RPC] Change the stop return value to be compliant wit Bitcoin Core by qlrd · Pull Request #520 · vinteumorg/Floresta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[RPC] Change the stop return value to be compliant wit Bitcoin Core #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2025
Merged

[RPC] Change the stop return value to be compliant wit Bitcoin Core #520

merged 2 commits into from
Jun 14, 2025

Conversation

qlrd
Copy link
Contributor
@qlrd qlrd commented Jun 13, 2025 •
edited
Loading

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other: adjust rpc stop return message.

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other:

Description

  • change return string "florestad stopping" to "Floresta stopping";
  • added a docstring for stop rpc command compliant with core;
  • include bitcoin core to stop test.

Notes to the reviewers

The Bitcoin Core stop rpc command return the message 'Bitcoin Core stopping' and our stop message retuns a little different message ('florestad stopping').

Author Checklist

  • I've followed the contribution guidelines
  • I've verified one of the following:
    • Ran just pcc (recommended but slower)
    • Ran just lint-features '-- -D warnings' && cargo test --release
    • Confirmed CI passed on my fork
  • I've linked any related issue(s) in the sections above

@Davidson-Souza Davidson-Souza added bug Something isn't working functional tests RPC Changes something with our JSON-RPC interface labels Jun 13, 2025
@qlrd qlrd changed the title Fix stop rpc [RPC] Change the stop return value to be compliant wit Bitcoin Core Jun 13, 2025
@qlrd qlrd force-pushed the fix-stop-rpc branch 4 times, most recently from b11c846 to 44719aa Compare June 13, 2025 17:21
@jaoleal
Copy link
Contributor
jaoleal commented Jun 13, 2025

can you retrigger the CI @qlrd

qlrd added 2 commits June 13, 2025 22:35
@qlrd
[RPC] Change the stop return value to be compliant wit Bitcoin Core
01f6e6e 
* change return string "florestad stopping" to "Floresta stopping";
* change the string value on its unit test;
* added a docstring for `stop` rpc command compliant with core.
@qlrd
Include bitcoin core to stop test
6ac2453
@qlrd
Copy link
Contributor Author
qlrd commented Jun 14, 2025 •
edited
Loading

can you retrigger the CI @qlrd

yup, sorry, the pcc wasn't passing due to my lack of attention in its unit test (just ran just lint-features)

Davidson-Souza
Davidson-Souza approved these changes Jun 14, 2025
View reviewed changes
Copy link
Collaborator
@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6ac2453

@Davidson-Souza Davidson-Souza merged commit 868ba4e into vinteumorg:master Jun 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza approved these changes

Assignees
No one assigned
Labels
bug Something isn't working functional tests RPC Changes something with our JSON-RPC interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qlrd @jaoleal @Davidson-Souza
0