Fixed error on destroying the instance of Hls
#2177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s change the destroy method to set fragments to a new map
(Object.create(null)) instead of null. After this is merged we’ll cut a
0.12.4
…On Thu, Mar 14, 2019 at 05:12 Tomohiro IKEDA ***@***.***> wrote:
This PR will...
This PR will fix error on destroying the instance of Hls.
The following is error detail ***@***.***).
1. Visit hls.js demo page <https://hls-js.netlify.com/demo/>
2. Change playlist file to Shaka-packager Widevine DRM (EME) HLS-fMP4
- Angel One Demo
<https://storage.googleapis.com/shaka-demo-assets/angel-one-widevine-hls/hls.m3u8>
3. Change playlist file to Big Buck Bunny - adaptive qualities
<https://video-dev.github.io/streams/x36xhzz/x36xhzz.m3u8>
[image: hls-destroy-error]
<https://user-images.githubusercontent.com/4006693/54344637-a76bd480-4684-11e9-9482-c31422181d44.png>
Why is this Pull Request needed?
This PR needed to change playlist file.
Are there any points in the code the reviewer needs to double check? Resolves
issues: Checklist
- changes have been done against master branch, and PR does not
conflict
- new unit / functional tests have been added (whenever applicable)
- API or design changes are documented in API.md
------------------------------
You can view, comment on, or merge this pull request online at:
#2177
Commit Summary
- Fixed error on destroying the instance of `Hls`
File Changes
- *M* src/controller/fragment-tracker.js
<https://github.com/video-dev/hls.js/pull/2177/files#diff-0> (7)
Patch Links:
- https://github.com/video-dev/hls.js/pull/2177.patch
- https://github.com/video-dev/hls.js/pull/2177.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2177>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEzwZCrnbfhXNyfk1nyewjXiYax5IZ6mks5vWhKMgaJpZM4bzo7J>
.
|
johnBartos
approved these changes
Mar 14, 2019
mrtska
pushed a commit
to mrtska/hls.js
that referenced
this pull request
Apr 14, 2019
mikrohard
pushed a commit
to Fora-si/hls.js
that referenced
this pull request
Oct 19, 2020
Signed-off-by: Jernej Fijacko <jernej.fijacko@fora.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
This PR will fix error on destroying the instance of
Hls.The following is error detail (hls.js@0.12.3).
Why is this Pull Request needed?
This PR needed to change playlist file.
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist