feat(smtp/sendMail): Also use timeout as readTimeout #2819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the connection is more likely to hand on read than connect.
s-ludwig
approved these changes
Mar 11, 2025
|
By the way, in order to avoid the extra work for a dedicated release, assuming that the sending is done from within a task, you should also be able to pretty easily work around the hang using something like this: auto task = Task.getThis();
auto watchdog = setTimer(30.seconds, { task.interrupt(); });
scope (exit) watchdog.stop();
sendMail(...); |
|
Thanks ! It's a simple one-file script so I went with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the connection is more likely to hand on read than connect.