windy plugin: drop auto-update code #361
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR removes the plugin’s automatic update mechanism by stripping all update-related state, actions, selectors, UI, and async fetch logic; it also drops the semver dependency, updates the initialization flow to skip update checks, and bumps the plugin version. Sequence Diagram: Simplified Plugin Initialization FlowsequenceDiagram
title Sequence Diagram: Simplified Plugin Initialization Flow
actor User
participant OpenPluginFunction as "sounding.tsx#openPlugin()"
participant PluginReduxStore as "Plugin Redux Store"
User ->> OpenPluginFunction: Initiates plugin opening
OpenPluginFunction ->> PluginReduxStore: dispatch(setStatus(PluginStatus.Ready))
OpenPluginFunction ->> PluginReduxStore: dispatch(changeLocation(currentLocation))
Updated Class Diagram: PluginState and pluginSlice ModificationsclassDiagram
direction LR
class PluginState {
+width: number
+height: number
+location: LatLon
+status: PluginStatus
+modelName: string
+timeMs: number
+favorites: Fav[]
+isZoomedIn: boolean
..Removed Fields..
-updateAvailable: boolean
-updateRequired: boolean
-availableVersion: string
}
class pluginSlice {
<<Redux Slice>>
+name: string
+initialState: PluginState
..Current Actions..
+setIsZoomedIn(payload: boolean)
+setFavorites(payload: Fav[])
+setModelName(payload: string)
+setTimeMs(payload: number)
+setWidth(payload: number)
+setHeight(payload: number)
+setLocation(payload: LatLon)
+setStatus(payload: PluginStatus)
..Removed Actions..
-setUpdateAvailable(payload: boolean)
-setUpdateRequired(payload: boolean)
-setAvailableVersion(payload: string)
..Removed Async Thunks..
-fetchPluginConfig()
..Current Selectors..
+selWidth(state: RootState): number
+selHeight(state: RootState): number
+selModelName(state: RootState): string
+selIsZoomedIn(state: RootState): boolean
+selLocation(state: RootState): LatLon
+selFavorites(state: RootState): Fav[]
+selStatus(state: RootState): PluginStatus
..Removed Selectors..
-selUpdateAvailable(state: RootState): boolean
-selUpdateRequired(state: RootState): boolean
-selAvailableVersion(state: RootState): string
}
pluginSlice ..> PluginState : uses as state schema
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThis change removes all plugin update/version checking logic and related UI from the windy-sounding library. It eliminates update-related Redux state, thunks, selectors, and UI components, and simplifies the plugin initialization flow by directly setting the plugin as ready without fetching or comparing remote configuration. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PluginUI
participant ReduxStore
User->>PluginUI: Open plugin
PluginUI->>ReduxStore: dispatch(setStatus('Ready'))
PluginUI->>ReduxStore: dispatch(changeLocation(currentLocation))
Note over PluginUI,ReduxStore: No remote config fetch or version check
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm warn config production Use Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Hey @vicb - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Drop the auto-update mechanism and clean up related code from the Windy Sounding plugin
Enhancements:
Build:
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores