Fix Buffer type
#20
Merged
Fix Buffer type
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the types a Uint8Array was accepted as a path. However, only a string is accepted as a path. A buffer is allowed too. The `Path` type has ben removed. Instead `Compatible` now accepts `VFileValue`, which can be either string or Buffer.
ChristianMurphy
approved these changes
Dec 30, 2021
5 tasks
wooorm
reviewed
Dec 31, 2021
Co-authored-by: Titus <tituswormer@gmail.com>
ChristianMurphy
approved these changes
Dec 31, 2021
wooorm
approved these changes
Jan 2, 2022
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
According to the types a Uint8Array was accepted as a path. However, only a string is accepted as a path. A buffer is allowed too.
The
Pathtype has ben removed. InsteadCompatiblenow acceptsVFileValue, which can be either string or Buffer.