10000 feat: introduce metrics-server by fitbeard · Pull Request #2665 · vexxhost/atmosphere · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: introduce metrics-server #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: introduce metrics-server #2665

wants to merge 1 commit into from

Conversation

fitbeard
Copy link
Contributor

This is initial introduction of components from atmosphere.common collection.

One thing about FluxCD i don't like is change tracking. We are spoiled by kubernetes.core.helm and how chart overrides are handled.

With FluxCD after we set:

metrics_server_helm_values:
  nodeSelector:
    openstack-control-plane: enabled

the only way to get rid of this value is:

metrics_server_helm_values:
  nodeSelector: null

@fitbeard
feat: introduce metrics-server
5e010f1 
Signed-off-by: Tadas Sutkaitis <tadas.sutkaitis@vexxhost.com>
@fitbeard fitbeard requested a review from mnaser May 16, 2025 15:41
@mnaser
Copy link
Member
mnaser commented May 16, 2025

@fitbeard ugh, that's quite annoying, that has been a long time limitation that we've been running into because of kubernetes.core.k8s which seems to be the root cause of this.

Do you thinwe can explore fixing it upstream or maybe a bug exists upstream? A really silly workaround for this could be using one of those raw Helm releases? But that's really stinky, the whole goal here is to move away from running CLIs like Helm.

Perhaps the way to go would be to run the kubectl apply instead until this is fixed since it's very likely kubectl already exists there? I also hate that approach, it feels that we can invest a bit of time to do the right thing here.

@fitbeard
Copy link
Contributor Author

@mnaser this is not a bug but feature fluxcd/kustomize-controller#372
I'll try to workaround this in atmosphere.common with something like current_helm_release.resources[0].spec.values -> new values -> diff -> null

@mnaser
Copy link
Member
mnaser commented May 16, 2025

@fitbeard I think I've seen similar behaviour with the kubernetes.core.k8s module, so I wonder if it's compounding. I think if you try and create a ConfigMap for example, it'll end up being created with 2 keys for example, but if you remove one of them and run the module again, it'll actually not remove it.

@fitbeard fitbeard mentioned this pull request May 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser Awaiting requested review from mnaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fitbeard @mnaser
0