Fix +: and -: unpacked array slicing when array has nonzero low index. (#5345) #5387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have just updated my github profile to match my name exactly with what I added to the CONTRIBUTOR file, but I'm not sure how to retrigger the contributor check. I suppose a maintainer may need to do this? My .gitconfig was already correct. |
|
As it runs on your repo I don't think I can retrigger the test. It should retest if you give github a new commit, or just modify the last one with a new date e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5345
Subtracts low index of unpacked array from msb & lsb calculations during plus/minus slice replacement. This is necessary when the low index is not zero, and I think was simply missed previously as this may not be a common coding style.
I have updated the existing t_unpacked_slice test so that it defines the source array parameters to have a negative low indices. I believe this should expand test coverage to this particular issue without sacrificing existing coverage. I'm open to this deserving its own test though.
I have done very few pull requests on github so please let me know if I've done something incorrectly here.