Fix display of empty headers on iOS 11 #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperkins
approved these changes
Aug 8, 2017
|
Looks good to me. Thanks, @nealyoung! |
dmiluski
reviewed
Aug 29, 2017
| var viewHeight: CGFloat { | ||
| switch self { | ||
| case .title: return UITableViewAutomaticDimension | ||
| case .view(let extremityView): return extremityView.bounds.height |
There was a problem hiding this comment.
This now loses auto-sizing for view extremities does it not?
rhaining
pushed a commit
that referenced
this pull request
Oct 4, 2017
* Revert "fixes footer and header heights on ios 11 to be automatic dimension if the view returns as 0 (#109)" This reverts commit 319a8b8. * Revert "Merge pull request #108 from nealyoung/extremity-height-fix" This reverts commit 2071110, reversing changes made to e002d86. * Bugfix: SectionFooterView AutoDimension Support Problem: 1. I noticed our app was manually laying out subviews in our sectionFooters when I didn't see the need to. 2. After recent changes, Group tableView's which had nil section extremity defaulted to zero, which drops the standard spacing between sections. Note in attatchment. Notable info: Statics currently has deploy target of iOS8, which did not yet support automatic sectionFooterView dimensioning. Solution: - Offer autosizing option which uses UITableViewAutomaticDimension rather than view's original bounds height. Retain original .view(_) case in the event some clients were already sizing beforehand limiting integration breaks. This also offers automatic margin adherence. - Bump deploy target to iOS9 for clean integration. - Revert 2 previous PRs - Default height for plain/grouped styles to play friendly with tableView's defaults. * Example: AutoSized Extremity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cann
2C8F
ot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
viewHeightonExtremitynon-optional and nil-coalesces to a height of 0 fornilsection extremities - fixes #105.