8000 kukui,corsola,asurada,cherry: disable afbc on mediatek devices by hexdump0815 · Pull Request #335 · velvet-os/imagebuilder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

kukui,corsola,asurada,cherry: disable afbc on mediatek devices #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

hexdump0815
Copy link
Collaborator

this is a temporary workaround for the broken afbc on mediatek drm to avoid trouble due to it - see
#314 for more information ... a fix on kernel side is on its way and this can be removed again once it is ready and made its way into the corresponding kernels

oak should not be affected as i think afbc (arm framebuffer compression) is used only between the gpu and drm and there is no useable gpu driver for the mt8173 yet ...

@hexdump0815 hexdump0815 requested a review from thenameisluk May 17, 2025 05:36
@thenameisluk
Copy link
Collaborator

@hexdump0815 shouldn't it be put in extra-files instead of some script creating it?

@hexdump0815
Copy link
Collaborator Author

i had that idea first as well, but then decided for the implementation used as it would not overwrite an existing environment file in case debian gets one one day or we will add one in one of the more global extra-files

@thenameisluk
Copy link
Collaborator

@hexdump0815
still

  • "the patch" should be just temporary
  • what kind of environment variables are we going to be applying to all systems?
  • /etc/environment is meant for backwards compatibility look here so we should use /etc/environment.d/*.conf instead (so it would not conflict with anything)

@hexdump0815
Copy link
Collaborator Author

good point - i wasn't aware of /etc/environment.d - then i'll change to use that via extra-files ... thanks for the hint

@thenameisluk thenameisluk linked an issue May 17, 2025 that may be closed by this pull request
@hexdump0815 hexdump0815 force-pushed the mediatek-drm-afbc-workaround branch from 21ecb2b to 24cf1d1 Compare May 19, 2025 20:58
@hexdump0815
Copy link
Collaborator Author

@thenameisluk - new version force-pushed into the branch

Copy link
Collaborator
@thenameisluk thenameisluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot closing '

i think it should look more like this
obraz

@hexdump0815 hexdump0815 force-pushed the mediatek-drm-afbc-workaround branch from 24cf1d1 to 49907df Compare May 19, 2025 21:40
@hexdump0815
Copy link
Collaborator Author

stupid copy and paste error on my end :) ... fixed and pushed again

Copy link
Collaborator
@thenameisluk thenameisluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

anyway why do we quote (") it
it's one word so it can't split
even mesa ^ doesn't do this

@hexdump0815
Copy link
Collaborator Author

i took it from somewhere where it was mentioned this way, but if it also works without for non-paths then i can push a version without tomorrow - now is bedtime first, will have to get up early tomorrow :)

this is a temporary workaround for the broken afbc on mediatek drm to
avoid trouble due to it - see
#314 for more
information ... a fix on kernel side is on its way and this can be
removed again once it is ready and made its way into the corresponding
kernels

oak should not be affected as i think afbc (arm framebuffer compression)
is used only between the gpu and drm and there is no useable gpu driver
for the mt8173 yet ...
@hexdump0815 hexdump0815 force-pushed the mediatek-drm-afbc-workaround branch from 49907df to 5425c7f Compare May 21, 2025 19:49
@hexdump0815
Copy link
Collaborator Author

@thenameisluk - sorry for the delay - without double-ticks now

@hexdump0815 hexdump0815 merged commit 6cbe72e into main May 21, 2025
@hexdump0815 hexdump0815 deleted the mediatek-drm-afbc-workaround branch May 21, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chromebook_corsola test image explodes if you update
2 participants
0