-
Notifications
You must be signed in to change notification settings - Fork 49
kukui,corsola,asurada,cherry: disable afbc on mediatek devices #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hexdump0815 shouldn't it be put in extra-files instead of some script creating it? |
i had that idea first as well, but then decided for the implementation used as it would not overwrite an existing environment file in case debian gets one one day or we will add one in one of the more global extra-files |
@hexdump0815
|
good point - i wasn't aware of /etc/environment.d - then i'll change to use that via extra-files ... thanks for the hint |
21ecb2b
to
24cf1d1
Compare
@thenameisluk - new version force-pushed into the branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24cf1d1
to
49907df
Compare
stupid copy and paste error on my end :) ... fixed and pushed again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
anyway why do we quote ("
) it
it's one word so it can't split
even mesa ^ doesn't do this
i took it from somewhere where it was mentioned this way, but if it also works without for non-paths then i can push a version without tomorrow - now is bedtime first, will have to get up early tomorrow :) |
this is a temporary workaround for the broken afbc on mediatek drm to avoid trouble due to it - see #314 for more information ... a fix on kernel side is on its way and this can be removed again once it is ready and made its way into the corresponding kernels oak should not be affected as i think afbc (arm framebuffer compression) is used only between the gpu and drm and there is no useable gpu driver for the mt8173 yet ...
49907df
to
5425c7f
Compare
@thenameisluk - sorry for the delay - without double-ticks now |
this is a temporary workaround for the broken afbc on mediatek drm to avoid trouble due to it - see
#314 for more information ... a fix on kernel side is on its way and this can be removed again once it is ready and made its way into the corresponding kernels
oak should not be affected as i think afbc (arm framebuffer compression) is used only between the gpu and drm and there is no useable gpu driver for the mt8173 yet ...