10000 prepare 4.0.0 release by mcfiredrill · Pull Request #669 · vcr/vcr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

prepare 4.0.0 release #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2017
Merged

prepare 4.0.0 release #669

merged 2 commits into from
Dec 1, 2017

Conversation

mcfiredrill
Copy link
Collaborator

@mcfiredrill mcfiredrill self-assigned this Nov 1, 2017
@ikapelyukhin
Copy link
Contributor

:neckbeard:👍

Copy link
Collaborator
@ecnalyr ecnalyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if our test suite was more reliable.

@krainboltgreene
Copy link
Contributor

We just recently fixed a big issue with the tests. Hmm...

@mcfiredrill
Copy link
Collaborator Author

No idea what the error is, look like the sinatra app is not starting properly maybe?
https://travis-ci.org/vcr/vcr/jobs/295664161#L1111

@ecnalyr
Copy link
Collaborator
ecnalyr commented Dec 1, 2017

A rebase should correct these test failures.

@krainboltgreene
Copy link
Contributor

Rebased, but there's also more coming in. Can someone give me the highlights?

@ecnalyr
Copy link
Collaborator
ecnalyr commented Dec 1, 2017

Recent changes were:

The only thing that may be noteworthy is the first point.

@krainboltgreene
Copy link
Contributor

Okay, I'll release tonight when I have the time.

@krainboltgreene krainboltgreene merged commit fb655c6 into master Dec 1, 2017
@krainboltgreene krainboltgreene deleted the release-4.0 branch December 1, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0