8000 Quick Find usage quirks · Issue #47 · variar/klogg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Quick Find usage quirks #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed 8000
5 tasks done
nocnokneo opened this issue Feb 1, 2019 · 5 comments
Closed
5 tasks done

Quick Find usage quirks #47

nocnokneo opened this issue Feb 1, 2019 · 5 comments
Assignees
@variar
Labels
type: bug type: feature
Milestone
2019.02

Comments

@nocnokneo
Copy link
nocnokneo commented Feb 1, 2019 •
edited by variar
Loading

A few issues with quick find:

  • The cursor jumps to the end of the quick find search field after every character (makes it very annoying to edit a search)
  • Hitting the Quick Find Ctrl+F shortcut should highlight any existing text that is already in the field (doesn't work if the Quick Find search already has focus)
  • Hitting the Quick Find Ctrl+F shortcut while text is selected in the log view or the filtered log view should set the Quick Find search term to that selected text
  • Standard shortcuts for next/previous search occurrence should work (e.g. Ctrl+G / Ctrl+Shift+G)
  • Next search occurrence should wrap (or at least have an option for it) with some sort of indication that the search has wrapped around the to beginning/end (maybe like Qt Creator does)
variar added a commit that referenced this issue Feb 2, 2019
@variar
Some quickfind improvements (#47)
c25e556
@variar
Copy link
Owner
variar commented Feb 2, 2019

@nocnokneo What version of klogg are you using?

The cursor jumps to the end of the quick find search field after every character (makes it very annoying to edit a search)

This sounds familiar but I can't find corresponding issue. Can't reproduce on Linux. Will test on Windows builds.

Next search occurrence should wrap (or at least have an option for it) with some sort of indication that the search has wrapped around the to beginning/end (maybe like Qt Creator does)

Will mark feature for next milestione

Hitting the Quick Find Ctrl+F shortcut should highlight any existing text that is already in the field (doesn't work if the Quick Find search already has focus)

Hitting the Quick Find Ctrl+F shortcut while text is selected in the log view or the filtered log view should set the Quick Find search term to that selected text

Standard shortcuts for next/previous search occurrence should work (e.g. Ctrl+G / Ctrl+Shift+G)

done in 19.02.0.339

@variar variar mentioned this issue Feb 2, 2019
Open
@variar variar self-assigned this Feb 2, 2019
@variar variar added this to the 2019.02 milestone Feb 2, 2019
@nocnokneo
Copy link
Author

What version of klogg are you using?
This sounds familiar but I can't find corresponding issue. Can't reproduce on Linux. Will test on Windows builds.

I was using the latest Windows continuous build. I also use klogg on Linux but with an older build. I don't remember noticing the issue on Linux but I can check later today with the latest Linux continuous build.

@variar
Copy link
Owner
variar commented Feb 4, 2019 •
edited
Loading

The issue is reproduced if incremental quick find is enabled. I usually turn it off because search is done in UI thread. Should be much more usable after fixing #49

variar added a commit that referenced this issue Feb 4, 2019
@variar
Remember quickfind cursor position (#47)
e6e7ead
@variar
Copy link
Owner
variar commented Feb 4, 2019

Should be fixed in 19.02.0.340

@nocnokneo
Copy link
Author

Thanks! Looks good.

@variar variar closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@variar variar

Labels
type: bug type: feature
Projects
None yet
Milestone
2019.02
Development

No branches or pull requests
2 participants
@nocnokneo @variar
0