8000 Allow reversing condition to render a file by fpseverino · Pull Request #482 · vapor/toolbox · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow reversing condition to render a file #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 5, 2025
Merged

Allow reversing condition to render a file #482

merged 7 commits into from
Jun 5, 2025

Conversation

fpseverino
Copy link
Member
@fpseverino fpseverino commented Jun 2, 2025 •
edited by penny-for-vapor bot
Loading

These changes are now available in 19.2.0

  • Check for a ! at the start of the if: condition to render a file, in which case it reverses the condition
  • Support shell completion scripts
  • Fix tests on Android

@fpseverino fpseverino requeste 8000 d review from MahdiBM and ptoffy June 2, 2025 17:09
@fpseverino fpseverino requested a review from 0xTim as a code owner June 2, 2025 17:09
@fpseverino fpseverino added the semver-minor Contains new APIs label Jun 2, 2025
@fpseverino fpseverino requested a review from gwynne as a code owner June 2, 2025 17:09
@codecov Codecov
Copy link
codecov bot commented Jun 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 39.35%. Comparing base (dbe0d58) to head (d02ee0b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/VaporToolbox/TemplateRenderer.swift 0.00% 16 Missing ⚠️
Sources/VaporToolbox/New.swift 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   40.53%   39.35%   -1.19%     
==========================================
  Files           7        7              
  Lines         634      648      +14     
==========================================
- Hits          257      255       -2     
- Misses        377      393      +16
Files with missing lines Coverage Δ
Sources/VaporToolbox/Vapor.swift 71.05% <100.00%> (-2.29%) ⬇️
Sources/VaporToolbox/New.swift 0.00% <0.00%> (ø)
Sources/VaporToolbox/TemplateRenderer.swift 10.71% <0.00%> (-0.83%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptoffy
ptoffy reviewed Jun 3, 2025
View reviewed changes
@fpseverino fpseverino merged commit ed8bca6 into vapor:main Jun 5, 2025
27 checks passed
@fpseverino fpseverino deleted the file-boolean-condition branch June 5, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@ptoffy ptoffy ptoffy approved these changes

@MahdiBM MahdiBM Awaiting requested review from MahdiBM

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

Assignees
No one assigned
Labels
semver-minor Contains new APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpseverino @0xTim @ptoffy
0