add NE_SW parameter to the designmatrix #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mattpitkin , this is the other PR merge into libstempo, so that the NE_SW parameter is properly taken into account. This PR should be fine as I just added parameters and variables that are passed through libstempo. If it looks fine to you, feel free to merge. I want to ask some of the testers of the other PR whether things work fine for them, before we merge that as well. Thanks for your help. |
|
Looks good to me. I'm happy to merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR related to adding tempo2 functionality to libstempo, so that the IPTA DR3 combination can be correctly analyzed with libstempo and enterprise.
The NE_SW parameter defining the average density of electrons from the spherical solar wind model is added to the designmatrix as a fully working parameter, that can be fixed (flag value 0), fitted (flag value 1) and marginalized for the data analysis.
E.g in the par file: NE_SW 7.9 0 or NE_SW 7.9 1