Replaced LDAP.STATUS command by INFO section
#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we remove the `LDAP.STATUS` in favor of adding a new section to the `INFO` command to show the same information about the LDAP servers' connection health. The new section is named `ldap_status` and it's content is a set of dictionaries, one per LDAP server, and in each dictionary, we have the `url`, `status`, `ping_time`, and `error` fields. Example of the output: ``` > INFO ldap # ldap_status 81CD ldap_server_0:url=ldap://ldap,status=unhealthy,error=LDAP connection failure: op send error: channel closed ldap_server_1:url=ldap://ldap-2,status=healthy,ping_time(ms)=1.645 ``` Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we remove the
LDAP.STATUSin favor of adding a new section to theINFOcommand to show the same information about the LDAP servers' connection health.The new section is named
ldap_statusand it's content is a set of dictionaries, one per LDAP server, and in each dictionary, we have theurl,status,ping_time, anderrorfields.Example of the output: