-
Notifications
You must be signed in to change notification settings - Fork 209
[Control Center] Add database backups section #4337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AI Language ReviewThe documentation in the "Backups" file is comprehensive and well-structured. However, there are a few areas where minor improvements or clarifications could enhance readability and consistency:
These are minor suggestions aimed at improving overall clarity. The document is already quite detailed and well-organized. |
|
||
The backup configuration using a cloud object store depends on which cloud object store is used. | ||
https://cloudnative-pg.io/documentation/1.25/appendixes/object_stores/[CouldNativePG's official documentation] lists common object stores and how to configure them. | ||
We provide example configurations for AWS S3 and other S3 compatible object stores, Microsoft Azure Blob Storage and Google Cloud Storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then the sentence needs rewording to make that obvious. Perhaps like this:
We provide example configurations for AWS S3 and other S3 compatible object stores, Microsoft Azure Blob Storage and Google Cloud Storage. | |
Example configurations are provided below for Microsoft Azure Blob Storage, Google Cloud Storage, Amazon Web Services (AWS) S3, and other S3 compatible object stores. |
- https://docs.microsoft.com/en-us/azure/storage/common/storage-configure-connection-string#configure-a-connection-string-for-an-azure-storage-account[Connection String] | ||
- Storage account name and https://docs.microsoft.com/en-us/azure/storage/common/storage-account-keys-manage[Storage account access key] | ||
- Storage account name and https://docs.microsoft.com/en-us/azure/storage/blobs/sas-service-create[Storage account SAS Token] | ||
- Storage account name and https://azure.github.io/azure-workload-identity/docs/introduction.html[Azure AD Workload Identity] properly configured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Storage account name and https://azure.github.io/azure-workload-identity/docs/introduction.html[Azure AD Workload Identity] properly configured. | |
- Storage account name and a properly configured https://azure.github.io/azure-workload-identity/docs/introduction.html[Azure AD Workload Identity]. |
|
||
= Backups | ||
|
||
Control Center manages databases using https://cloudnative-pg.io[CloudNativePG], an open-source Kubernetes operator to manage PostgreSQL workloads on any supported Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I you have to guess, we should remove it or re-word it.
Add the following lines to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comprehensive, yet concise documentation. Nice job.
Document the process of making database backups, scheduling automatic backups, and recovery from a backup in Control Center.
Fixes https://github.com/vaadin/control-center/issues/892