8000 Revert "COMP: Some compilers need both string.h & strings.h" by hjmjohnson · Pull Request #735 · vxl/vxl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "COMP: Some compilers need both string.h & strings.h" #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

Revert "COMP: Some compilers need both string.h & strings.h" #735

merged 1 commit into from
Dec 10, 2019

Conversation

hjmjohnson
Copy link
Contributor

This reverts commit 901b41b.

This resolves issue #734 of compilation failure, but
re-introduces a compiler warning about implicitly defined
function on some compilers.

@hjmjohnson hjmjohnson self-assigned this Dec 10, 2019
@hjmjohnson
Revert "COMP: Some compilers need both string.h & strings.h"
dbfdf8c 
This reverts commit 901b41b.

This resolves issue #734 of compilation failure, but
re-introduces a compiler warning about implicitly defined
function on some compilers.

Additional changes to use

v3p/geotiff/cpl_serv.h:104:36: warning: implicit declaration of function ‘strcasecmp’ [-Wimplicit-function-declaration]
@hjmjohnson hjmjohnson force-pushed the strings-on-windows-failure branch from ece9839 to dbfdf8c Compare December 10, 2019 20:21
@hjmjohnson
Copy link
Contributor Author

@mundyj could you please confirm that this new code resolves your problem on windows?

@mundyj
Copy link
Contributor
mundyj commented Dec 10, 2019

That did fix the problem but this branch caused the following error
Severity Code Description Project File Line Suppression State
Error C2039 'min': is not a member of 'std' (compiling source file D:\software\terra_dsm\external\vxl\core\vnl\vnl_bignum_traits.cxx) vnl D:\software\terra_dsm\external\vxl\core\vnl\vnl_bignum.h 222

If I include in vnl_bignum.h the problem is resolved.
Again, this is with Visual Studio 2019
Thanks!

@hjmjohnson hjmjohnson merged commit 482c837 into master Dec 10, 2019
@hjmjohnson hjmjohnson deleted the strings-on-windows-failure branch February 13, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hjmjohnson hjmjohnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjmjohnson @mundyj
0