8000 feat(useSorted): accept getter function as source by wvffle · Pull Request #3249 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(useSorted): accept getter function as source #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

feat(useSorted): accept getter function as source #3249

merged 1 commit into from
Jul 30, 2023

Conversation

wvffle
Copy link
Contributor
@wvffle wvffle commented Jul 22, 2023 •
edited by ghost
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Enables users to use a getter function for useSorted source.

Additional context

🤖 Generated by Copilot at 1a12c68

Added support for getter functions as source parameter for useSorted function. Updated type definitions and documentation for packages/core/useSorted/index.ts.

🤖 Generated by Copilot at 1a12c68

  • Change the type of the source parameter of the useSorted function to accept a getter function that returns an array, in addition to a ref or a plain value, to improve flexibility and consistency (link, link)
  • Update the type definitions of the useSorted function in the file packages/core/useSorted/index.ts to match the change in the source parameter type (link)

@antfu antfu added this pull request to the merge queue Jul 30, 2023
Merged via the queue into vueuse:main with commit 33a12b2 Jul 30, 2023
@wvffle wvffle deleted the wvffle/useSorted-getter branch July 30, 2023 13:44
@renovate renovate bot mentioned this pull request Sep 9, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wvffle @antfu
0