8000 fix(watchImmediate): fix overload signature by ferreira-tb · Pull Request #3114 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(watchImmediate): fix overload signature #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix(watchImmediate): fix overload signature #3114

merged 1 commit into from
Jun 6, 2023

Conversation

ferreira-tb
Copy link
Contributor
@ferreira-tb ferreira-tb commented May 25, 2023 •
edited by ghost
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Description

Fixes the overload signature of the watchImmediate function, which incorrectly omitted the deep property when it should have omitted the immediate property.

🤖 Generated by Copilot at d190404

Refactor watchImmediate function to remove unnecessary immediate option. Simplify the type definition and usage of WatchOptions in packages/shared/watchImmediate/index.ts.

🤖 Generated by Copilot at d190404

  • Omit the immediate option from the WatchOptions type for the watchImmediate function and its overloads, since it is always true for this function (packages/shared/watchImmediate/index.ts, link, link, link)

@antfu antfu merged commit 4b4e6c2 into vueuse:main Jun 6, 2023
@renovate renovate bot mentioned this pull request Oct 9, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferferga ferferga ferferga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferreira-tb @ferferga @antfu
0