8000 fix(nuxt): don't require `@vueuse/core` installed at root by danielroe · Pull Request #4698 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(nuxt): don't require @vueuse/core installed at root #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2025
Merged

fix(nuxt): don't require @vueuse/core installed at root #4698

merged 2 commits into from
Apr 6, 2025

Conversation

danielroe
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Description

Currently this will always fail as @vueuse/core is a dependency of this package

Nuxt will resolve the paths correcty...

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 6, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Apr 6, 2025
@danielroe danielroe changed the title fix(nuxt): do not try to check for package existence fix(nuxt): don't require @vueuse/core installed at root Apr 6, 2025
43081j
43081j approved these changes Apr 6, 2025
View reviewed changes
Copy link
Collaborator
@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

this should fix the various pnpm problems for anyone curious

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 6, 2025
ilyaliao
ilyaliao approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member
@ilyaliao ilyaliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💚

@43081j 43081j added this pull request to the merge queue Apr 6, 2025
@43081j
Copy link
Collaborator
43081j commented Apr 6, 2025

have tried it locally and it worked 👍 so happy to merge this

Merged via the queue into vueuse:main with commit 17a46a9 Apr 6, 2025
8 checks passed
@ilyaliao ilyaliao mentioned this pull request Apr 7, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6776
Reviewers

@43081j 43081j 43081j approved these changes

@ilyaliao ilyaliao ilyaliao approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroe @43081j @ilyaliao
0