8000 fix(tryOnMounted): pass target to getLifeCycleTarget by Eazash · Pull Request #4685 · vueuse/vueuse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(tryOnMounted): pass target to getLifeCycleTarget #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

fix(tryOnMounted): pass target to getLifeCycleTarget #4685

merged 1 commit into from
Apr 8, 2025

Conversation

Eazash
Copy link
Contributor
@Eazash Eazash commented Apr 1, 2025

Before submitting the PR, please make sure you do the following

  • [ x ] Read the Contributing Guidelines.
  • [ x ] Read the Pull Request Guidelines.
  • [ x ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [ x ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

A possible regression was introduced in #3658 where tryOnMounted was not passing it's target argument to getLifeCycleTarget. This meant that the passed callback would always be called within the current instance, regardless of the target passed. This PR fixes that by passing the target through.

Additional context

I haven't been able find uses of tryOnMounted where target is specified

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 1, 2025
@OrbisK
Copy link
Collaborator
OrbisK commented Apr 1, 2025

/cc @Doctor-wu #3658 can you confirm this?

@Doctor-wu
Copy link
Member
Doctor-wu commented Apr 1, 2025 •
edited
Loading

@Eazash Could you provide a minimal reproduction of issue, I remember that target pass was deleted intentionally.

And it fix this #3649

@OrbisK
Copy link
Collaborator
OrbisK commented Apr 1, 2025

@Eazash Could you provide a minimal reproduction of issue, I remember that target pass was deleted intentionally.

And it fix this #3649

#3649 seems to fix an vue2 bug. From v12.0, VueUse no longer supports Vue 2. maybe we dont need this "fix" anymore?

@Doctor-wu
Copy link
Member

@Eazash Could you provide a minimal reproduction of issue, I remember that target pass was deleted intentionally.
And it fix this #3649

#3649 seems to fix an vue2 bug. From v12.0, VueUse no longer supports Vue 2. maybe we dont need this "fix" anymore?

Oh, happy to hear that. Then this would be ok for me if it doesn't break any test case

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 1, 2025
@antfu antfu merged commit 16551af into vueuse:main Apr 8, 2025
8 checks passed
@renovate renovate bot mentioned this pull request Apr 17, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrbisK OrbisK OrbisK approved these changes

@ilyaliao ilyaliao ilyaliao approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Eazash @OrbisK @Doctor-wu @ilyaliao @antfu
0