feat!: drop CJS build, now it's ESM-only #4581
Conversation
|
Why are we still generating CJS stuff? Why are we including CJS stuff in the tgz (cannot remove |
|
Just a note about node10 module resolution (I guess @antfu also wants to drop support for it, shouldn't be a problem): it is resolving correctly the types but not the implementation (subpackages exports other than default => check firebase package at aretypeswrong). I'm testing on my local without generating CJS stuff... |
This comment was marked as resolved.
This comment was marked as resolved.
|
Uhmm, rigth now https://arethetypeswrong.github.io/?p=%40vueuse%2Fcore%4012.8.1 https://arethetypeswrong.github.io/?p=%40vueuse%2Fcore%4013.0.0-beta.1 |
|
I guess we can map |
|
It doesn't seem to exist regardless of our export map 😬 |
Yeah, missing in the tgz file 😬😬 NOTE: the mjs file without the import (it should be inlined), only types using the import, looks like an error in the rollup config file. @vueuse/core/index.mjs screenshot |
|
That was a mistake, fixed in 3f5da12 |
Consider the majority of Vue users are using bundlers, dropping CJS should only affect CJS-SSR usage, which is considered rather nitch.
We plan to ship this as v13 on 2025/3/10 (Monday), with this as the sole breaking change.
If you have any feedback, please leave comments below. Thanks.