fix(useMutationObserver): stop watching before cleaning up #4037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it's unlikely this will cause real world issues due to all calls being synchronous at the moment (and thus should be executed within the same tick), it's better to first stop watching and then cleanup the observer. Otherwise if one of these methods ever gets transformed into an async method then during the cleanup call the watcher could be triggered and create a new observer
antfu
approved these changes
Jun 12, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).Description
Although it's probably unlikely this will cause real world issues due to all calls being synchronous at the moment (and thus should be executed within the same tick), it's better to first stop watching and then cleanup the observer.
Otherwise if one of these methods ever gets transformed into an async method then during the cleanup call the watcher could be triggered and create a new observer
Additional context