8000 feat(KeepAlive): pause deactivated components with freeze prop by ferferga · Pull Request #13304 · vuejs/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(KeepAlive): pause deactivated components with freeze prop #13304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: minor
Choose a base branch
from
Draft

feat(KeepAlive): pause deactivated components with freeze prop #13304

wants to merge 1 commit into from
+10 −0

Conversation

ferferga
Copy link
Contributor
@ferferga ferferga commented May 10, 2025 •
edited
Loading

Fixes #5386

As described in the issue, when a component is deactivated, the effects of that component will still be running. In the same way the defer attribute was added to Teleport to keep backwards-compat, a freeze prop has been added here, so users can opt-in to this new behavior.

Requires #13303< 8000 /a> so there's a walkable tree of effect scopes when pausing/resuming, hence a draft PR.
Tests and docs will be created once that PR is merged.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ferferga ferferga mentioned this pull request May 10, 2025
Open
@ferferga ferferga marked this pull request as draft May 10, 2025 14:57
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+78 B) 38.3 kB (+17 B) 34.5 kB (+24 B)
vue.global.prod.js 159 kB (+78 B) 58.5 kB (+20 B) 52 kB (-66 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB 18.3 kB 16.7 kB
createApp 55 kB 21.4 kB 19.5 kB
createSSRApp 59.2 kB 23.1 kB 21.1 kB
defineCustomElement 59.8 kB 22.9 kB 20.9 kB
overall 69.3 kB (+78 B) 26.6 kB (+17 B) 24.2 kB (+3 B)

@pkg-pr-new pkg.pr.new
Copy link
pkg-pr-new bot commented May 10, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13304

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13304

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13304

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13304

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13304

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13304

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13304

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13304

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13304

vue

npm i https://pkg.pr.new/vue@13304

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13304

commit: 9b0a939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ferferga
0