This repository was archived by the owner on May 13, 2020. It is now read-only.
Fixed the scatter part of fan #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plotting was not done on an axis, meaning that the plotting crashed
|
Hello @paalge, Sorry we weren't able to test this pull request here, did you mean to close the pull request? Without creating a branch on the vtsuperdarn davitpy repository, it can be hard to test this pull request. |
|
Sorry for making a mess, somehow I thought this was merged into develop, and removed the branch. |
|
Hey @paalge I've confirmed the bug that you said was there and that your pull request fixes the bug. Thank you for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plotting was not done on an axis, meaning that the plotting crashed giving the error message:
File "", line 1, in
File "/usr/local/lib/python2.7/dist-packages/davitpy-0.5-py2.7-linux-x86_64.egg/davitpy/pydarn/plotting/fan.py", line
345, in plotFan
myFig.scatter(xctr, y[1] * (.98 - w * .025), s=.1 * pts[w],
AttributeError: 'Figure' object has no attribute 'scatter'
Testing can be done with
import datetime
import os
import matplotlib.pyplot as plt
from davitpy import pydarn
pydarn.plotting.fan.plotFan(datetime.datetime(2013,3,16,16,30),['fhe','fhw'],param='power',gsct=False,coords='mag',fill=False)