Fix client dialer log #1568
Merged
Fix client dialer log #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log such as: tunneling request to tcp:www.google.com:80 via tcp:x.x.x.x:443 the second "tcp" is misleading when using mKcp or quic transport Remove the second "tcp" and add the correct logging for transport dialer: - transport/internet/tcp: dialing TCP to tcp:x.x.x.x:443 - transport/internet/quic: dialing quic to udp:x.x.x.x:443
Codecov Report
@@ Coverage Diff @@
## master #1568 +/- ##
==========================================
- Coverage 39.29% 39.21% -0.09%
==========================================
Files 602 605 +3
Lines 35480 35630 +150
==========================================
+ Hits 13941 13971 +30
- Misses 20003 20100 +97
- Partials 1536 1559 +23
Continue to review full report at Codecov.
|
AkinoKaede
reviewed
Feb 7, 2022
Co-authored-by: 秋のかえで <autmaple@protonmail.com>
AkinoKaede
reviewed
Apr 6, 2022
| @@ -75,7 +75,7 @@ func (c *Client) Process(ctx context.Context, link *transport.Link, dialer inter | |||
| if err != nil { | |||
| return newError("failed to find an available destination").AtWarning().Base(err) | |||
| } | |||
| newError("tunneling request to ", destination, " via ", server.Destination()).WriteToLog(session.ExportIDToError(ctx)) | |||
| newError("tunneling request to ", destination, " via ", network, ":", server.Destination().NetAddr()).WriteToLog(session.ExportIDToError(ctx)) | |||
There was a problem hiding this comment.
I think it will be misleading when using mKCP and QUIC.
There was a problem hiding this comment.
What if we change it to this:
tun... to... via ... drive...
or transport...
tun... to tcp:google.com:443 via tcp:127.0.0.1:1080 transport quic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log such as:
tunneling request to tcp:www.google.com:80 via tcp:x.x.x.x:443the second "tcp" is misleading when using mKcp or quic transport
Remove the second "tcp" and add the correct logging for transport dialer: