8000 syntax role modifiers by jurgenvinju · Pull Request #1835 · usethesource/rascal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

syntax role modifiers #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 87 commits into
base: main
Choose a base branch
from
Draft

syntax role modifiers #1835

wants to merge 87 commits into from

Conversation

jurgenvinju
Copy link
Member
@jurgenvinju jurgenvinju commented Jul 7, 2023 •
edited
Loading

This PR implements syntax role modifiers.

SyntaxModifiers.pdf

@codecov
Copy link
codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.73377% with 439 lines in your changes missing coverage. Please review.

Project coverage is 47%. Comparing base (71174c0) to head (c45eab9).

Files with missing lines Patch % Lines
src/org/rascalmpl/types/ModifySyntaxRole.java 23% 207 Missing and 28 partials ⚠️
src/org/rascalmpl/ast/SyntaxRoleModifier.java 20% 90 Missing and 1 partial ⚠️
src/org/rascalmpl/library/Type.java 33% 24 Missing ⚠️
src/org/rascalmpl/ast/Type.java 34% 20 Missing and 1 partial ⚠️
src/org/rascalmpl/types/RascalTypeFactory.java 43% 12 Missing and 1 partial ⚠️
...ascalmpl/semantics/dynamic/SyntaxRoleModifier.java 55% 12 Missing ⚠️
...org/rascalmpl/values/parsetrees/SymbolFactory.java 35% 10 Missing and 1 partial ⚠️
src/org/rascalmpl/ast/NullASTVisitor.java 0% 6 Missing ⚠️
src/org/rascalmpl/types/RascalType.java 0% 6 Missing ⚠️
src/org/rascalmpl/runtime/$RascalModule.java 0% 5 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@           Coverage Diff            @@
##              main   #1835    +/-   ##
========================================
- Coverage       47%     47%    -1%     
- Complexity    6342    6385    +43     
========================================
  Files          764     767     +3     
  Lines        63177   63808   +631     
  Branches      9431    9541   +110     
========================================
+ Hits         29945   30191   +246     
- Misses       31010   31373   +363     
- Partials      2222    2244    +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jurgenvinju jurgenvinju mentioned this pull request Jul 17, 2023
Open
@jurgenvinju jurgenvinju mentioned this pull request Aug 15, 2023
Closed
@jurgenvinju
Merge branch 'main' into syntax-role-modifiers
a3abc9b
@jurgenvinju
regenerated parser and AST hierarchy to include SyntaxRoleModifiers i…
79804b4 
…n type symbols
@jurgenvinju
working on syntax roles
06f10c5
@jurgenvinju
Merge branch 'main' into syntax-role-modifiers
b809bef
@jurgenvinju
Merge branch 'main' into syntax-role-modifiers
23ebd62
@jurgenvinju
added Symbol-level syntax and semantics of syntax role modifiers
647d636
@jurgenvinju
added bootstrap declarations for Symbols that represent syntax role m…
e889835 
…odifiers
@jurgenvinju
implemented isOpen and IsParametrized for syntax types
36587c9
@jurgenvinju
fixed copy and paste bug
f9c7869
@jurgenvinju
partially implemented java-level syntax and semantics of syntax role …
5fb57c8 
…modifiers
@jurgenvinju
implementing all the Type operations on Syntax modifiers
1e7e1d0
@jurgenvinju
implemented lub on syntax modifiers
49cb9c0
@jurgenvinju
implemented Type.glbWithModifySyntax and added subtype cases to Type …
17de9ab 
…and ParseTree
@jurgenvinju
fixed compiler error and removed unused imports
acea788
jurgenvinju added 30 commits May 27, 2025 18:52
@jurgenvinju
fixed semi-merge
a380145
@jurgenvinju
more merge fixes in pom.xml
5f0ec6f
@jurgenvinju
fixed compilation errors due to new randomValue interface from vallang
bf3f30a
@jurgenvinju
use module names betterfor test suite descriptions instead of "Module…
e0ac269 
…Tester" as the class of all test cases
@jurgenvinju
started implementation of syntax role modifiers in the checker.
a331572
@jurgenvinju
fixed typos
71896f0
@jurgenvinju
removed duplicate rule
9e2b7ed
@jurgenvinju
fixed NPE in vallang by making sure that ModifySyntaxRole::equals(nul…
1f1e566 
…l) returns false via @DavyLandman for the equals contract on null
@jurgenvinju
more tests
f4fc8d5
@jurgenvinju
added subtype for syntax role modifiers
f1e04ce
@jurgenvinju
simplified asyntaxRoleModifiers by grouping all modifiers into one si…
3b0d16f 
…ngle operator parameterized by SyntaxRole
@jurgenvinju
fixed typo
dd768d8
@jurgenvinju
removed old asubtype on asyntax, alexical, and replaced asyntaxRoleMo…
aba69e8 
…difier
@jurgenvinju
added missing alub
b784370
@jurgenvinju
commented out experimental extension of outerComparable1
cc10ae2
@jurgenvinju
added glb for asyntaxRoleModifiers
242f5ca
@jurgenvinju
added the collect for all syntax role modifiers
ed103b1
@jurgenvinju
added code generator for runtime type instances of SyntaxRoleModifier…
17040db 
…s by calling the RascalTypeFactory and recursion on the single type parameter
@jurgenvinju
added comment to explain
b3a1cd8
@jurgenvinju
added minimal amount of error checking to the collect of syntax role …
6acfd83 
…modifiers
@jurgenvinju
fixed typo
0095182
@jurgenvinju
fix
1dac7e2
@jurgenvinju
removed dead code
f8166d2
@jurgenvinju
sorted extends
a36be1b
@jurgenvinju
Merge branch 'main' into syntax-role-modifiers
2cd0529
@jurgenvinju
Merge branch 'use-installed-typepal-if-project-not-available' into sy…
6b0dd45 
…ntax-role-modifiers
@jurgenvinju
Merge branch 'main' into syntax-role-modifiers
5908a4d
@jurgenvinju
Merge branch 'main' into syntax-role-modifiers
22a61e0
@jurgenvinju
Merge branch 'main' into syntax-role-modifiers
0e1cf0e
@jurgenvinju
Merge branch 'main' into syntax-role-modifiers
c45eab9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavyLandman DavyLandman DavyLandman left review comments

@rodinaarssen rodinaarssen Awaiting requested review from rodinaarssen

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurgenvinju @DavyLandman
0