8000 Chore/fix tests by bomoko · Pull Request #3926 · uselagoon/lagoon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Chore/fix tests #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

Chore/fix tests #3926

merged 3 commits into from
Jun 18, 2025

Conversation

bomoko
Copy link
Contributor
@bomoko bomoko commented Jun 17, 2025

Nip.io parsing of urls has changed since being moved to sslip.io

In order to fix the testing framework, we've made a small change to the testing domains (adding a .a. prefix) to ensure that our ip addresses are correctly parsed.

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Description

Explain the details for making this change. What existing problem does the pull request solve?

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@bomoko bomoko marked this pull request as ready for review June 18, 2025 00:36
@bomoko bomoko requested a review from shreddedbacon June 18, 2025 01:01
Copy link
Member
@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are looking good now, happy to :shipit:

@bomoko bomoko merged commit 77fb733 into main Jun 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0